Skip to content

Add new prop to configure tree node selectable #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add new prop to configure tree node selectable #3083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/tree/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,16 @@ const propTypes = {
* Styles to be added to the top-level `ul` element. Useful for `overflow:hidden`.
*/
listStyle: PropTypes.object,
/**
* Indicate whether a tree node is selectable
*/
treeNodeSelectable: PropTypes.boolean,
};

const defaultProps = {
assistiveText: {},
getNodes: (node) => node.nodes,
treeNodeSelectable: true,
};

/* Flattens hierarchical tree structure into a flat array. The
Expand Down Expand Up @@ -189,6 +194,9 @@ class Tree extends React.Component {
}

handleSelect = ({ event, data, clearSelectedNodes, fromFocus }) => {
if (!this.props.treeNodeSelectable) {
return;
}
// When triggered by a key event, other nodes should be deselected.
if (clearSelectedNodes) {
// TODO: This bad design. This is state modfication. State should be changed via setState only.
Expand Down