Skip to content

feat(phase5): explainable memory operations (v3.10)#160

Merged
salishforge merged 3 commits into
mainfrom
feat/phase5-explainable-memory
Jul 26, 2026
Merged

feat(phase5): explainable memory operations (v3.10)#160
salishforge merged 3 commits into
mainfrom
feat/phase5-explainable-memory

Conversation

@salishforge

Copy link
Copy Markdown
Owner

Summary

Feature 2 of the Phase 5 split from umbrella #129 (F1 landed in #137, F5+F6 in #136/#138). No schema migration — pure code feature.

  • explain=true on GET /memory/:id/query — each result carries an ExplanationFactor[] (rank_score, epistemic_status weight 1.0/0.5/0.2, search_mode, temporal_decay when decay is active).
  • GET /memory/:id/explain?warm_id= + MemoryManager.explainMemory() — state report for a single warm memory: scores, epistemic status, access patterns, and standing against the sleep-cycle score thresholds. The outlook flags are deliberately scoped (would_evict_by_threshold, would_flag_low_confidence); capacity eviction and outcome/contradiction-driven revision depend on live cross-table state and are not predicted.
  • Full checklist parity the umbrella branch lacked: memforge_explain MCP tool wired to a real client method (the umbrella version was a stub returning memoryHealth), TS + Python SDK methods including both resilient wrappers, tool-definitions, OpenAPI entries.
  • Hardening from adversarial review (17-agent workflow, 13 raw → 8 confirmed findings, all addressed): warm_id bounded to int8 at REST + MCP boundaries (was: Postgres 22003 → 500), invalid agent id on /explain returns 400 like sibling routes, query cache key extracted to queryKey() in cache.ts so the explain flag's key participation is pinned by unit tests without Redis.

Test evidence

Suite Result
npm run type-check 0 errors
npm run lint clean
tests/explainable-memory.test.ts (new) 27/27
npm run test:http 36/36
npm run test:integration 24/24
npm run test:epistemic-confidence 30/30

Pre-existing issues surfaced by review (out of scope, filing separately)

  • Python SDK QueryResult dataclass rejects unknown response keys — already incompatible with v3.8/v3.9 response fields at HEAD.
  • /entities and /graph return 500 (not 400) for invalid agent ids — same pattern this PR fixes for /explain.
  • epistemic query param missing from the OpenAPI query-path spec (F1 gap).

🤖 Generated with Claude Code

https://claude.ai/code/session_011xCqQo49d3CEbn6oEvb3Ru

Feature 2 of the Phase 5 split (umbrella #129): every retrieval can say
why, and any warm memory can be asked where it stands.

- query(): opt-in explain=true attaches ExplanationFactor[] per result
  (rank_score, epistemic_status weight, search_mode, temporal_decay)
- explainMemory() + GET /memory/:id/explain?warm_id= reports scores,
  access patterns, and standing against the sleep-cycle score
  thresholds. Flags are scoped honestly (would_evict_by_threshold,
  would_flag_low_confidence): capacity eviction and the outcome /
  contradiction revision channels depend on live cross-table state and
  are deliberately not predicted here.
- memforge_explain MCP tool wired to the real client method; TS +
  Python SDKs including both resilient wrappers; OpenAPI entries
- query cache key extracted to queryKey() in cache.ts so the explain
  flag's participation in the key is unit-testable without Redis
- warm_id validated to int8 range at REST and MCP boundaries; invalid
  agent ids on /explain return 400 like sibling routes

No schema migration — pure code feature.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011xCqQo49d3CEbn6oEvb3Ru
salishforge and others added 2 commits July 26, 2026 19:40
* feat(phase5): causal memory graph (v3.10)

Feature 3 of the Phase 5 split (umbrella #129): MemForge learns which
events tend to follow which, and can answer "what led here" and "what
happens next".

- causal_edges table (migration-v3.10.sql + canonical schema, RLS,
  agent-scoped FKs to warm_tier with CASCADE)
- Sleep Phase 6.1 mines memory_sequences for repeated content-level
  A→B patterns (md5 of 50-char prefixes, the Phase 5.5 technique) —
  the umbrella's row-pair grouping was unsatisfiable under the table's
  UNIQUE constraint and could never mine an edge. One edge per
  pattern, anchored to the earliest surviving pair so re-mining
  updates in place and FK cascade self-heals evicted anchors. Not
  skip-gated: the phase's input accumulates independently of its own
  change history, so the zero-change gate would permanently disable
  mining for young agents. Count surfaces as
  SleepCycleResult.causal_edges_updated.
- getCausalChain(): recursive CTE traversal (causes|effects, depth
  clamped 1-10, 50-row cap, ordered depth then strength)
- predict(): context match → outgoing edges → ranked events.
  probability = confidence × (1 − e^(−strength/30)) — monotonic,
  never saturated (raw strength × confidence clamps to 1.0 for
  virtually every mined edge). Shared-pool matches are excluded from
  the cause-id list (different id space than warm_tier), and effects
  are confined to the requested namespace.
- GET /memory/:id/causal + POST /memory/:id/predict, memforge_causal_chain
  + memforge_predict MCP tools wired to real client methods, TS +
  Python SDKs incl. resilient wrappers, tool-definitions, OpenAPI
- tests/causal-graph.test.ts: 39 tests (traversal incl. cycles/clamps/
  cap/ordering, predict incl. namespace + pool-collision, Phase 6.1
  mining incl. cv weighting + anchor stability + true re-confirmation
  step, pruning, HTTP status paths, migration shape + RLS)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011xCqQo49d3CEbn6oEvb3Ru

* feat(phase5): hierarchical abstraction engine (v3.11) (#164)

Feature 4 of the Phase 5 split (umbrella #129): Sleep Phase 5.11
distills cross-cutting principles from accumulated meta-reflections
into a queryable abstractions store.

- abstractions table (migration-v3.11.sql + canonical schema): level
  CHECK (principle|strategy|mental_model), stored md5 content_hash
  with UNIQUE (agent_id, level, namespace, content_hash) — the
  umbrella's ON CONFLICT DO NOTHING had no conflict target and would
  have duplicated every principle every cycle. RLS + grants.
- Phase 5.11: gated on LLM presence, token budget, and >= 3
  meta-reflections; prompt carries the codebase-standard injection
  guard, wraps reflection content via wrapUserContent, and states the
  schema's own limits (max 10, under 2000 chars, empty-array escape)
  so one overlong item does not sink the batch silently. Re-derivation
  is corroboration: ON CONFLICT keeps GREATEST confidence and revives
  a deactivated principle only when the fresh derivation is confident
  (>= 0.5); the conditional WHERE keeps change counts honest. Age-based
  deactivation of stale sub-0.2 principles. Not skip-gated (input
  accumulates independently). Cancellation checkpoint before the LLM
  call so canceled dream runs stop paying. runPhase now records real
  per-phase token spend in sleep_phase_analytics; count surfaces as
  SleepCycleResult.principles_extracted.
- getAbstractions()/getPrinciples(), GET /principles + /abstractions
  routes, memforge_principles + memforge_mental_models MCP tools wired
  to real client methods (honest description: only 'principle' is
  auto-extracted today), TS + Python SDKs incl. resilient wrappers,
  tool-definitions, OpenAPI with shared Abstraction component.
- tests/abstractions.test.ts: 39 tests — read paths, extraction incl.
  dedup/revival/confidence-raise/skip-gate immunity/token attribution/
  budget + window gates/malformed + schema-invalid + missing-key LLM
  output, deactivation age and scope boundaries, ordering tiebreak,
  HTTP status paths, migration shape + RLS.


Claude-Session: https://claude.ai/code/session_011xCqQo49d3CEbn6oEvb3Ru

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@salishforge
salishforge merged commit 2970a38 into main Jul 26, 2026
12 checks passed
@salishforge
salishforge deleted the feat/phase5-explainable-memory branch July 26, 2026 19:44
salishforge added a commit that referenced this pull request Jul 26, 2026
main's only unique commit is 2970a38 — the squash-merge of the collapsed
F2+F3+F4 stack, whose content this branch already carries as individual
commits (verified: the branch-vs-main diff is exactly the F7 + contested
feature delta, purely additive except for lines those features replace).
Recording the merge with our tree resolves the squash-vs-branch conflicts
without content changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011xCqQo49d3CEbn6oEvb3Ru
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant