Simplify WaitGroup implementation
#958
Merged
+31
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #958 will degrade performances by 5.28%Comparing Summary
Benchmarks breakdown
|
|
Is there any other benefit than code size reduction. It seems codspeed doesn't like it at all. |
Veykril
force-pushed
the
veykril/push-rqyrkyttxpol
branch
from
7a3884e to
ef1c5dc
Compare
|
No there isn't. I was curious about the perf impact, I agree this isn't great. Checking if we can actually simplify our impl now |
Veykril
force-pushed
the
veykril/push-rqyrkyttxpol
branch
from
ef1c5dc to
1b15e41
Compare
Veykril
changed the title
WaitGroup impl with crossbeam'sWaitGroup implementation
|
Hm, we could get rid of the additional |
|
@ibraheemdev could you take a look at this PR? |
ibraheemdev
reviewed
Aug 5, 2025
ibraheemdev
approved these changes
Aug 5, 2025
Veykril
force-pushed
the
veykril/push-rqyrkyttxpol
branch
2 times, most recently
from
f1f158f to
ee184dd
Compare
Co-authored-by: Ibraheem Ahmed <[email protected]>
Veykril
force-pushed
the
veykril/push-rqyrkyttxpol
branch
from
ee184dd to
9b4da36
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.