-
Notifications
You must be signed in to change notification settings - Fork 185
Run fixpoint per strongly connected component #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fix serde attribute
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #999 will degrade performances by 14.34%Comparing Summary
Benchmarks breakdown
|
Hmm, I'm surprised that this is even slower than #995, considering that most logic now lives directly in Either way. I think there are some optimization opportunities:
|
e14d70d
to
179050d
Compare
a2b3da6
to
058fa5b
Compare
let database_key_index = self.database_key_index(key_index); | ||
|
||
let _claim_guard = match self.sync_table.try_claim(zalsa, key_index) { | ||
let _claim_guard = match self.sync_table.try_claim(zalsa, key_index, false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be true
or false
???
Run a single fixpoint iteration for strongly connected components
to avoid exponential runtime for deeply nested cycles.
TODO:
maybe_changed_after
cycle_nested_deep_conditional_changed::the_test
sometimes hangs or panics