hack: Update controller-gen to v0.19.0 #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With go1.25, there's a breaking change[1] from golang.org/x/tools pulled in by controller tools for which a fix is available in either v0.24.1 (and above) or v0.25.1 (and above). This minimum version of golang.org/x/tools is only included from controller tools v0.16.4. We make use of this opportunity to fetch the latest version. [1] golang/go#74462 Signed-off-by: Anoop C S <[email protected]>
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go1.25, there's a breaking change from golang.org/x/tools pulled in by controller tools for which a fix is available in either v0.24.1 (and above) or v0.25.1 (and above). This minimum version of golang.org/x/tools is only included from controller tools v0.16.4. We make use of this opportunity to fetch the latest version.