percentage-fontsize plugin implementation #688
Conversation
specifying font size as a percent value as used in phpBB system.
abetis
force-pushed
the
percentage-fontsize-plugin
branch
from
344f1d2 to
28e44d7
Compare
abetis
changed the title
src/lib/SCEditor.js
Outdated
| * @memberOf SCEditor.prototype | ||
| */ | ||
| base.wysiwygGetTags = function (tagName) { | ||
| return wysiwygDocument.getElementsByTagName(tagName); |
There was a problem hiding this comment.
This returns a live ordered collection of Elements by tag name.
Either be explicit about it in its documentation or change the code into something most programmers would expect from it
There was a problem hiding this comment.
I'll check other methods, maybe it will be easier to just inject the HTML tags instead of using execCommand
| * @type {Object} | ||
| * @private | ||
| */ | ||
| var sizes = [50, 75, 100, 150, 200]; |
There was a problem hiding this comment.
Does this behave like a constant? If so, turn the variable name into CAPS
Personally, I'd have a default value but allow setting options to change it
There was a problem hiding this comment.
good point. updating.
There was a problem hiding this comment.
Is there a documentation for plugin configuration fomat?
Couldn't find any documentation for format.js configuration for example...
| sceditor.command.set('size', { | ||
| exec: commandHandler, | ||
| txtExec: commandHandler, | ||
| tooltip: 'Font Size' |
There was a problem hiding this comment.
Use _ function to make it translatable or allow it to be translable somehow.
There was a problem hiding this comment.
Please explain what do you mean here.
_ for what function?
What does "translatable" means?
There was a problem hiding this comment.
It's a function named _. See: https://www.sceditor.com/api/sceditor/underscore/
"translatable" <=> To be able to have a different text on the node based on the current language
There was a problem hiding this comment.
Sorry, but I don't understand what function do you mean that have to be with underscore or translatable.
I'm basing my code the same way as is appears in the format plugin that Sam wrote and as defaultCommands.js code looks like...
There was a problem hiding this comment.
Ah, OK. The code sends tooltips through the translation function when displaying:
https://github.com/samclarke/SCEditor/blob/master/src/lib/SCEditor.js#L712
I had forgotten about that.
src/plugins/percentage-fontsize.js
Outdated
| var size; | ||
|
|
||
| if (!fontSize) { | ||
| fontSize = element.style['font-size']; |
There was a problem hiding this comment.
element.style['font-size'] -> element.style.fontSize
Change the method to inject the HTML.
The plugin allows specifying font size as a percent value as used in phpBB system.