famfamfam sprites generation tool #692
Conversation
There was a problem hiding this comment.
I dunno if @samclarke would accept this but, for me to accept (see below), it has to work on all OSs and, preferably, not introduce a new programming language.
| @@ -0,0 +1,48 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Change the script language into a platform-agnostic one. For the sake of this project's survival we must not limit image contributions to linux users (even if only through an emulator or whatnot).
Because, to build, SCE already requires node.js (javascript), I highly recommend you using that. It will allow us to, more easily, create a workflow including this process and without introducing a new language.
imagemagick exists for all 3 major platforms so that is not an issue.
Take a look at this. It might help you getting started on the communications part.
There was a problem hiding this comment.
Sorry, but I will leave it to someone else.
As I intend to use that script for my next PR (facebook video) and other changes specific to my system that won't be pushed, I propose to change the order of the icons in the sprite image to be in alphanumeric order and not sporadic as it is now and change the url.png to link.png to have all the icons match the command names.
I can push those changes separately.
Since there is no tool at all to create the sprite image and it have to be done manually, I don't see a reason why not to use it until there will be a better solution proposed by someone else.
I don't intend to create the image manually for my next changes. Any merge in the image will not be possible without a tool.
There was a problem hiding this comment.
Please activate to allow changes from maintainers
^
There was a problem hiding this comment.
it is allowed on my side...
|
@samclarke I checked famfamfam's licence and this script is allowed. Is it good to go after transforming it into javascript for Node.js? |
|
Ohhh... now I see that there is a website with all the famfamfam icons... |
Script that combines all the PNGs from src/themes/icons/src/famfamfam into a single PNG sprite file and generates the famfamfam.less according to the icons order.
grip.png and grip-rtl.png are added at the end.
Don't see any easier way to add new icons.
Sorry Windoze guys, works only on Linux, don't know what tools do you have in the MS world.
Required ImageMagick installed.