refactor: use environment variables for oauth2-proxy config #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lablans
approved these changes
Oct 9, 2024
Threated
requested changes
Oct 17, 2024
Comment on lines
+140
to
+141
| - OAUTH2_PROXY_CLIENT_ID=${OIDC_PRIVATE_CLIENT_ID} | ||
| - OAUTH2_PROXY_CLIENT_SECRET=${OIDC_CLIENT_SECRET} |
There was a problem hiding this comment.
I would quote these just to be sure I dont know if a client secret can contain a = or something else that will mess up docker
Suggested change
| - OAUTH2_PROXY_CLIENT_ID=${OIDC_PRIVATE_CLIENT_ID} | |
| - OAUTH2_PROXY_CLIENT_SECRET=${OIDC_CLIENT_SECRET} | |
| - OAUTH2_PROXY_CLIENT_ID="${OIDC_PRIVATE_CLIENT_ID}" | |
| - OAUTH2_PROXY_CLIENT_SECRET="${OIDC_CLIENT_SECRET}" |
| - OAUTH2_PROXY_REDIRECT_URL="https://${HOST}${OAUTH2_CALLBACK}" | ||
| - OAUTH2_PROXY_OIDC_ISSUER_URL=${OIDC_ISSUER_URL} | ||
| - OAUTH2_PROXY_SCOPE=openid profile email | ||
| - OAUTH2_PROXY_CODE_CHALLENGE_METHOD=true |
There was a problem hiding this comment.
This was set to S256 whatever that means. If you know what your doing I trust you I just noticed its different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the configuration of both oauth2-proxy instances to use environment variables for configuration.