feat: use project overarching vars #239
Conversation
There was a problem hiding this comment.
BEAM_TAG gets exported here https://github.com/samply/bridgehead/blob/develop/bridgehead#L90
There was a problem hiding this comment.
I'm not too happy about having different places where the tags are set, but we can tackle that in the future as it touches the Environment topic.
|
So I dont know about the future use cases of the top level |
you mean to rename the file or rename the variable names? |
bridgehead
Outdated
| setHostname | ||
| optimizeBlazeMemoryUsage | ||
| [ -e ./$PROJECT/vars ] && source ./$PROJECT/vars | ||
| [ -e ./$PROJECT/vars ] && source ./$PROJECT/vars ./vars |
There was a problem hiding this comment.
I think the source of ./vars should happen before the more specific project vars so that they can override the default and get set regardless of project vars existing or not
The file name |
Threated
left a comment
Threated
left a comment
There was a problem hiding this comment.
Also we should not need the source versions in each vars file as we source it before sourcing $PROJECT/vars
| setHostname | ||
| optimizeBlazeMemoryUsage | ||
| [ -e ./$PROJECT/vars ] && source ./$PROJECT/vars | ||
| [ -e ./$PROJECT/vars ] && source ./versions ./$PROJECT/vars |
There was a problem hiding this comment.
Sorry to bother you again I meant sourcing ./versions regardless of ./$PROJECT/vars existing. I think it always exits so it should not really matter but if we have the check that anyway
adapting changes from #221 proposal