Skip to content

Fix to null types as schema instantiation argument #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DaniyelMe
Copy link
Contributor

Creating a new instance of Schema with null argument should not be acceptable as a valid object.
This fix will make sure that new Schema(null); will throw an error "Schema must be an object".

Adding a test to cover this case.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files           7        7           
  Lines         135      135           
  Branches       48       48           
=======================================
  Hits          134      134           
  Misses          1        1           
Impacted Files Coverage Δ
src/index.js 99.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78963ab...da7476c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant