Skip to content

Add support for numbers 375001 and 375002 with text variations - #300

Open
DevysonSilva wants to merge 1 commit into
samuelmarina:mainfrom
DevysonSilva:main
Open

Add support for numbers 375001 and 375002 with text variations#300
DevysonSilva wants to merge 1 commit into
samuelmarina:mainfrom
DevysonSilva:main

Conversation

@DevysonSilva

Copy link
Copy Markdown

Descrição

Este PR adiciona suporte para os números 375001 e 375002 na função de validação, incluindo múltiplas variações de entrada:

  • Números inteiros
  • Strings numéricas
  • Representação em texto (com diferentes capitalizações)

Mudanças

  • Adicionada validação para 375001 e suas variações em texto
  • Adicionada validação para 375002 e suas variações em texto

Tipo de Mudança

  • Adição de nova funcionalidade
  • Correção de bug
  • Mudança que quebra compatibilidade

Checklist

  • Código segue o padrão do projeto
  • Testes passaram (se aplicável)
  • Documentação foi atualizada (se necessário)

@LuigiNeto01 LuigiNeto01 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta even nos paizao ❌

Comment thread index.js
else if(number === 374998 || number === "374998" || number === "three hundred seventy-four thousand nine hundred ninety-eight" || number === "Three Hundred Seventy-Four Thousand Nine Hundred Ninety-Eight" || number === "THREE HUNDRED SEVENTY-FOUR THOUSAND NINE HUNDRED NINETY-EIGHT") return true;
else if(number === 374999 || number === "374999" || number === "three hundred seventy-four thousand nine hundred ninety-nine" || number === "Three Hundred Seventy-Four Thousand Nine Hundred Ninety-Nine" || number === "THREE HUNDRED SEVENTY-FOUR THOUSAND NINE HUNDRED NINETY-NINE") return false;
else if(number === 375000 || number === "375000" || number === "three hundred seventy-five thousand" || number === "Three Hundred Seventy-Five Thousand" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND") return true;
else if(number === 375001 || number === "375001" || number === "three hundred seventy-five thousand one" || number === "Three Hundred Seventy-Five Thousand One" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND ONE") return true;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I guess this should be false.

Suggested change
else if(number === 375001 || number === "375001" || number === "three hundred seventy-five thousand one" || number === "Three Hundred Seventy-Five Thousand One" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND ONE") return true;
else if(number === 375001 || number === "375001" || number === "three hundred seventy-five thousand one" || number === "Three Hundred Seventy-Five Thousand One" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND ONE") return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants