Skip to content

Conversation

@just-oliver
Copy link

@just-oliver just-oliver commented Dec 25, 2025

Changes

  1. Addtion of arg and kwargs to reset method allowing BoxoHack.reset to accept the seed arguments provided by Gymnasium API.
  2. Removed the possibility of method _is_episode_end ever calling while self._goal_pos_set is undefined, by initalizing as None during class init
  3. FileNotFoundError chained to actual raised error ModuleNotFoundError to appease flake8
  4. minihack/data directory defined directly rather than ambiguous minihack.dat definition
  5. Test added to test the ability to reset these specific environments, ensures that the boxoban dataset levels are installed during test. shutil.rmtree cleans up if previously uninstalled after test runs. Test runs without issue.
  6. Black commit requirement version changed from stable to 23.12.1. As most recent stable version of Black only is supported for Python >3.10.

All Submissions:

IMPORTANT: if this Pull Request concerns an existing issue, please provide the GitHub issue number, otherwise please create an issue first.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Closing issues

Closes #29.

1. Removal of circular imports of LevelGenerator and MinihackNavigation from the top level minihack package.
2.Reset method altered so that it prevents throwing an error by unused seed argument provided by the Gymnasium api.
3._goal_pos_set referenced in end check method without being referenced causing a crash. Now set as none during class init.
downloads of boxoban level changed to specify minihack/dat directory
…ily if not available and removes after running test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Issue with reset method of Boxohack environment due to Gymnasium API change

1 participant