Skip to content

Attempt to improve reliability#35

Closed
samayala22 wants to merge 22 commits into
samyycX:betafrom
samayala22:fix-disconnect
Closed

Attempt to improve reliability#35
samayala22 wants to merge 22 commits into
samyycX:betafrom
samayala22:fix-disconnect

Conversation

@samayala22
Copy link
Copy Markdown
Contributor

@samayala22 samayala22 commented Jun 5, 2026

Related to swiftly-solution/swiftlys2#325

not too familiar with the codebase but this is the furthest I could go based on the logs, dumps and messages with Skuzzi on discord.

  • try to mitigate risky native hook during disconnect teardown
  • use concurrent dict for subscribed inventories to prevent data races when syncing
  • prevent DB sync to happen with a stale inventory pointer (tentative fix to a problem observed in cases where the stale pointer window is large like cross region DB round-trip of 100ms+)
  • use int with CAS to guard from multiple db syncs that can arise from multiple players joining
  • use concurrent dict for music kit service, like the rest of the services

Maybe beta branch should be updated from main before considering merging this PR ?

@samayala22
Copy link
Copy Markdown
Contributor Author

Closing because it's still crashing. Will be working on my fork instead.

@samayala22 samayala22 closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants