Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
songmichael11
requested changes
Apr 4, 2026
Collaborator
songmichael11
left a comment
songmichael11
left a comment
There was a problem hiding this comment.
Not sure if filtering works when searching now. But otherwise great lgtm besides that
| ); | ||
| }) | ||
| .slice(0, 50); | ||
| const hasSearch = searchQuery.trim().length > 0; |
Collaborator
There was a problem hiding this comment.
Not sure if this is intended, but seems like this means that if I search for "sandbox" and try and filter for only Roles by clicking on the Roles tab, this doesn't apply this filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
made it so that if you search for a review, it also shows the corresponding role + company in the results and vice versa
Motivation and Context
Closes #[ticket]
How has this been tested?
Screenshots (if appropriate):
Types of changes
pnpm db:generateand verified generated SQL migration files inpackages/db/drizzleChecklist: