Skip to content

fixed wonky review form things#414

Merged
gpalmer27 merged 3 commits intomainfrom
review-form-fixes
Apr 5, 2026
Merged

fixed wonky review form things#414
gpalmer27 merged 3 commits intomainfrom
review-form-fixes

Conversation

@gpalmer27
Copy link
Copy Markdown
Collaborator

@gpalmer27 gpalmer27 commented Apr 2, 2026

Description

  • benefits section works now
  • you can scroll if you have any autocomplete section open
  • if you click again on any autocomplete section then it closes the dropdown

Motivation and Context

Closes #[ticket]

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database migration
    • Ran pnpm db:generate and verified generated SQL migration files in packages/db/drizzle

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cooper Ready Ready Preview, Comment Apr 5, 2026 0:30am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
cooper-auth Skipped Skipped Apr 5, 2026 0:30am
cooper-docs Skipped Skipped Apr 5, 2026 0:30am

Request Review

Copy link
Copy Markdown
Collaborator

@tracyyh tracyyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmmmm

@tracyyh
Copy link
Copy Markdown
Collaborator

tracyyh commented Apr 3, 2026

wait while youre at it can you make the dropdown for locations the same width as the trigger

Copy link
Copy Markdown
Collaborator

@songmichael11 songmichael11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can make it so that clicking outside the dropdown also makes it close the dropdown? While also keeping the scrolling functionality? Not sure if those r mutually exclusive or smth.

Everything else LGTM YAY

Copy link
Copy Markdown
Collaborator

@songmichael11 songmichael11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmmmmm

@gpalmer27 gpalmer27 merged commit ff931bf into main Apr 5, 2026
10 checks passed
@gpalmer27 gpalmer27 deleted the review-form-fixes branch April 5, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants