Skip to content

Fixing SEO Issues from Lighthouse#33

Open
dajinchu wants to merge 1 commit intomasterfrom
lighthouse
Open

Fixing SEO Issues from Lighthouse#33
dajinchu wants to merge 1 commit intomasterfrom
lighthouse

Conversation

@dajinchu
Copy link
Copy Markdown
Member

Lighthouse is a tool embedded in Chrome devtools that shows performance, accessibility, best practices, and SEO issues in websites. Currently it complains that our tap targets are too close, and aren't mobile friendly:
https://developers.google.com/web/tools/lighthouse/audits/tap-targets

The Google Search Console says exactly the same thing. This impacts our search engine rankings on Google. Here, I add a fix to pass the Lighthouse test. The footer ends up looking kind of big and spaced out, but it's not too bad?

There are a lot more accessibility issues in Lighthouse we should address, but this one is the only one categorized as "SEO," the rest are just listed as accessibility issues.

@vercel
Copy link
Copy Markdown

vercel bot commented May 21, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://sandboxneucom-git-lighthouse.sandboxneu1.now.sh

Copy link
Copy Markdown
Member

@ryandrew14 ryandrew14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This padding is huge. I'd want to make the padding equal between the header and the links but that would make the footer ridiculously tall. Is there any way we can fix the score without making it this big? There are websites (like https://www.paperlessparts.com/) that I know have a perfect lighthouse score that get around this.

@sarah-witt
Copy link
Copy Markdown
Member

Thanks for doing this!

@dajinchu
Copy link
Copy Markdown
Member Author

This padding is huge. I'd want to make the padding equal between the header and the links but that would make the footer ridiculously tall. Is there any way we can fix the score without making it this big? There are websites (like https://www.paperlessparts.com/) that I know have a perfect lighthouse score that get around this.

As far as I can tell, Lighthouse also flags paperlessparts footer for the same tap target issue.

@ryandrew14
Copy link
Copy Markdown
Member

Does the google.com footer have issues? It looks pretty close together.

@ArunJ98
Copy link
Copy Markdown
Member

ArunJ98 commented May 21, 2019

Atleast on mobile, the padding seems fine to me. Haven’t check on web yet tho. Either way, most of our traffic seems to be from us linking our website in other places and I anticipate this will be largest driving force to visits to our site. Therefore, I think it’s fine to sacrifice a little on SEO in favor of a more professional looking website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants