Skip to content

SearchBar Component#364

Open
vi0let-byte wants to merge 3 commits intomainfrom
rooms-search-bar
Open

SearchBar Component#364
vi0let-byte wants to merge 3 commits intomainfrom
rooms-search-bar

Conversation

@vi0let-byte
Copy link
Copy Markdown
Contributor

Pull Request

Modified existing SearchBar component to take its placeholder text as a param. This enables reuse for Rooms.

Closes

Type of Change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a PCP (ie changes in deps, database, infrastructure, or package exports)

Testing

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
The only thing this really affects is visuals so I clicked around on the website and made sure the placeholder was still correct.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • I have run a build for the entire monorepo
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All commits are atomic and my branch is cleaned (no WIP commits)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
searchneu Error Error Apr 1, 2026 9:41pm
searchneu-docs Ready Ready Preview, Comment Apr 1, 2026 9:41pm

Request Review

@vi0let-byte vi0let-byte marked this pull request as draft March 26, 2026 16:13
@vi0let-byte vi0let-byte marked this pull request as ready for review March 26, 2026 16:13
Copy link
Copy Markdown
Collaborator

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the linting and formatting errors please! After that everything here looks good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rooms Page Search Bar

2 participants