Gcc 15 #361
Merged
Gcc 15 #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertinterestingnamehere
force-pushed
the
gcc15
branch
21 times, most recently
from
6be7403 to
684a393
Compare
insertinterestingnamehere
force-pushed
the
gcc15
branch
from
684a393 to
7461183
Compare
They (erroneously) assume that the __sync_val_compare_and_swap intrinsic is a pure founction and that, if the resulting value is discarded, the corresponding function cal can be discarded too. Some of the older code in qthreads liked to write atomic stores using CAS operations with discarded return values. While there's technically nothing wrong with that, it's an odd idiom now that we have c11 atomics. This switches those cases over to c11 atomic stores instead.
insertinterestingnamehere
force-pushed
the
gcc15
branch
from
82bac48 to
045b782
Compare
insertinterestingnamehere
merged commit af9195e
into
sandialabs:main
367 of 377 checks passed
|
Note: updates for nvc, icx, and aocc included here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.