fix(mm): add stability for minimega commands across hosts#110
Merged
Conversation
7 tasks
nblair2
force-pushed
the
fix/mm2
branch
3 times, most recently
from
f4b696d to
f3cbb03
Compare
GhostofGoes
suggested changes
Jun 1, 2026
Contributor
|
looks good to me, no other comments other than the couple minor things above |
* Client Active - wait for up to 5 minutes for a client to be active before throwing an error (mirrors the core phenix Go code behavior) * Command IDs - read the ID from the cc response Data (mm_command_id) deprecate the racy mm_last_command * Multi-host scans - mm_cc_all_hosts reads every host's response instead of failing on a sibling's "no client" error * Exit-code wait - mm_cc_exitcode_wait bounded-polls to ride out the gap between a response being counted and the exit code being written Add some tests for mm cc
cmulk
approved these changes
Jun 6, 2026
Contributor
|
Are the phenix environment variables documented anywhere? If not, I can make an issue and take a task to document those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(mm): add stability for minimega commands across hosts
Description
Address stability across multi-host uses. Add a timeout/retry for getting responses from the mesh.
Add a deprecation notice to mm_last_command, and remove any calls here. This function isn't race-safe. I left in because I am not sure if any custom apps are using it.
Note
I have 2 commits here, intentionally not squashed. The second is to fix an unrelated issue from #105 to make the format checks happy.
Related Issue
Type of Change
Please select the type of change your pull request introduces:
New featureDocumentation updateOther (please describe):Checklist
I have made corresponding changes to the documentation.Additional Notes
N/A