fix: batch agent recorder import integrity state#32
Merged
Conversation
Summary - Add a flush hook to record adapters and let integrity wrapping choose immediate or on-flush state persistence. - Keep live run integrity state crash-durable after each record, but persist import integrity state once after the replayable batch completes. - Document the import/run durability distinction and add coverage for on-flush state persistence. Testing - node scripts/sync-platform-package-versions.js - cd tools/agent-recorder && cargo fmt --check - cd tools/agent-recorder && cargo test --quiet - cd tools/agent-recorder && cargo test --examples --quiet Notes/Risks - Interrupted integrity-backed imports may leave partial output/state alignment that should be discarded or rerun from a clean/aligned backend and state file. - This preserves per-record durability for run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runintegrity persistence immediate for live crash tolerance, while makingimportpersist integrity state once after the replayable batch completes.agent-recorderto0.1.1for this patch-level performance/durability improvement.Testing
node scripts/sync-platform-package-versions.jscd tools/agent-recorder && cargo fmt --checkcd tools/agent-recorder && cargo test --quietcd tools/agent-recorder && cargo test --examples --quietcd tools/agent-recorder && target/debug/agent-recorder --versionNotes/Risks
runbehavior remains conservative and persists integrity state after each new record.