Skip to content

Fix C4267 by changing return type #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aeris170 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix C4267 by changing return type #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TextEditor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class IMGUI_API TextEditor
inline bool IsShowLineNumbersEnabled() const { return mShowLineNumbers; }
inline void SetShortTabsEnabled(bool aValue) { mShortTabs = aValue; }
inline bool IsShortTabsEnabled() const { return mShortTabs; }
inline int GetLineCount() const { return mLines.size(); }
inline size_t GetLineCount() const { return mLines.size(); }
Copy link
Copy Markdown
Owner

@santaclose santaclose Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree that we don't want the warning, does it also go away if you use unsigned int ? would prefer that over size_t

Copy link
Copy Markdown
Author

@aeris170 aeris170 Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't. size_t is 64bits on win64 while unsigned int is 32bits.

void SetPalette(PaletteId aValue);
PaletteId GetPalette() const { return mPaletteId; }
void SetLanguageDefinition(LanguageDefinitionId aValue);
Expand Down