-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
feat(apply): add preflight liveness and role-match gate #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
santifer
merged 4 commits into
santifer:main
from
luochen211:codex/apply-preflight-gate
Jun 11, 2026
+35
−5
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
264dd19
feat(apply): add preflight liveness gate
luochen211 9ac847d
fix(apply): clarify preflight execution order
luochen211 f3ac568
docs: renumber apply workflow steps
luochen211 520d29c
Merge main into codex/apply-preflight-gate — keep #821 form-field con…
santifer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Duplicate "Step 5" heading.
The document contains two sections both labeled "Step 5":
When the preflight gate was inserted as Step 5, subsequent sections were not renumbered. This breaks the documentation structure and will confuse users following the workflow.
📝 Proposed fix: renumber subsequent sections
And update the final section:
Also applies to: 77-77
🤖 Prompt for AI Agents