feat: add provenance metadata for pipeline entries#894
Conversation
|
Warning Review limit reached
More reviews will be available in 1 minute and 39 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds lightweight provenance metadata to pipeline entries stored in ChangesPipeline Provenance Metadata
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scan.mjs`:
- Line 239: The assignment const verified = verifiedAt || 'unverified' is
redundant given the default parameter verifiedAt = 'unverified'; replace it with
a nullish-coalescing fallback to preserve safety for null/undefined but allow
empty strings: change to const verified = verifiedAt ?? 'unverified' (or remove
the local const and use verifiedAt directly) so the code is clearer and not
masking valid empty-string values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f8459be8-9de8-4b25-a842-efc62066ae31
📒 Files selected for processing (4)
docs/SCRIPTS.mdmodes/pipeline.mdscan.mjstest-all.mjs
|
Addressed the CodeRabbit nitpick on provenance metadata formatting. Validation: |
|
Closing under the acceptance criterion explained in full on #890: core takes what the candidate uses; project-artifact tooling lives outside the core. For this one specifically: provenance fields have no consumer today — when something needs them, the schema should be designed against that consumer, not ahead of it. The companion-repo door from #890 applies to this one too. 🙏 |
Summary
source,provider, andverified_at, usingverified_at=unverifiedwhen scans run without--verify.Fixes #878
Tests
node --check scan.mjs && node --check test-all.mjsnode test-all.mjs --quick— 166 passed, 0 failed, 7 existing README.ua personal-data warningsSummary by CodeRabbit
Documentation
New Features
verified_at=unverifiedfor transparency.