Skip to content

fix(generate-pdf): silent no-op on Windows - build file:// URLs with pathToFileURL #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuhia wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(generate-pdf): silent no-op on Windows - build file:// URLs with pathToFileURL #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions generate-pdf.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { chromium } from 'playwright';
import { resolve, dirname } from 'path';
import { readFile } from 'fs/promises';
import { mkdirSync } from 'fs';
import { fileURLToPath } from 'url';
import { fileURLToPath, pathToFileURL } from 'url';

const __dirname = dirname(fileURLToPath(import.meta.url));

Expand Down Expand Up @@ -221,7 +221,7 @@ async function generatePDF() {
const fontsDir = resolve(__dirname, 'fonts');
html = html.replace(
/url\(['"]?\.\/fonts\//g,
`url('file://${fontsDir}/`
`url('${pathToFileURL(fontsDir).href}/`
);
// Close any unclosed quotes from the replacement (handles all font formats)
html = html.replace(
Expand Down Expand Up @@ -262,7 +262,7 @@ export async function renderHtmlToPdf(html, outputPath, opts = {}) {
// Set content with file base URL for any relative resources
await page.setContent(html, {
waitUntil: 'load',
baseURL: `file://${baseDir}/`,
baseURL: `${pathToFileURL(baseDir).href}/`,
});

// Wait for fonts to load
Expand Down Expand Up @@ -299,7 +299,7 @@ export async function renderHtmlToPdf(html, outputPath, opts = {}) {
}
}

const isMain = process.argv[1] && import.meta.url === `file://${resolve(process.argv[1])}`;
const isMain = process.argv[1] && import.meta.url === pathToFileURL(resolve(process.argv[1])).href;
if (isMain) {
generatePDF().catch((err) => {
console.error('❌ PDF generation failed:', err.message);
Expand Down