Conversation
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
|
FYI, I will discuss this with Sandro on Monday. He has voiced reservations. Please do not merge until then. |
|
The concern that Sandro raises (summarizing from a DM thread) is that, if go.mod has e.g. Also, there may be concerns about caching of action outputs that would cause runs to get stuck on old Go versions even if it could theoretically choose a newer bugfix version, were it not for the caching. |
|
@majewsky for me the |
|
toolchain was removed in a release a few months ago, it should no longer does that. I think we get 1.25.0 if any dep is using that unless we are one minor version higher. If any dep is using 1.25.1 we get at least that. |
@kayrus pointed out this setting in sapcc/maintenance-controller#369 (comment), and its specification sounds like what we want. This would be a nice way to reduce some noise in the git log because we don't have to change version strings all the time when new Go versions are released.