Add Helm chart OCI package publishing to GitHub Container Registry#466
Add Helm chart OCI package publishing to GitHub Container Registry#466
Conversation
notandy
force-pushed
the
pushHelmChartToGhcr
branch
2 times, most recently
from
4c903d1 to
826cd95
Compare
notandy
force-pushed
the
pushHelmChartToGhcr
branch
from
826cd95 to
c762f63
Compare
|
This is by the way how the rendered workflow looks like: https://github.com/cobaltcore-dev/openstack-hypervisor-operator/blob/d97775c6effcb039f879efe2935a1c7d36054179/.github/workflows/helm-oci-package-ghcr.yaml |
|
|
||
| `lint` configures whether the Helm chart should be linted with `helm lint` before packaging and pushing. Defaults to `true`. | ||
|
|
||
| `dependencyUpdate` configures whether chart dependencies should be updated with `helm dependency update` before packaging and pushing. Defaults to `true`. |
There was a problem hiding this comment.
This is within the lock file constraints, right? Than fine for me.
There was a problem hiding this comment.
correct, it's just a regular helm dep update, so only the lock file will be updated. It shouldn't hurt and only matters if the chart has dependency - so I've enabled it by default.
There was a problem hiding this comment.
Pull request overview
Adds support to generate a GitHub Actions workflow that packages and pushes a Helm chart to GHCR (OCI), including new configuration knobs and README documentation.
Changes:
- Document new
githubWorkflow.pushHelmChartToGhcrconfiguration inREADME.md. - Introduce
internal/ghworkflow/workflow_helm.goto generate a Helm OCI publish workflow (lint/package/push + optional auto-versioning). - Wire the new workflow into rendering and add corresponding config/constants.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents Helm chart publishing workflow configuration and behavior. |
| internal/ghworkflow/workflow_helm.go | New workflow generator for packaging/pushing Helm charts to GHCR (OCI). |
| internal/ghworkflow/render.go | Ensures the Helm workflow is rendered alongside existing workflows. |
| internal/core/constants.go | Adds HelmSetupAction constant for azure/setup-helm. |
| internal/core/config.go | Adds PushHelmChartToGhcrConfig to GitHub workflow configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
notandy
force-pushed
the
pushHelmChartToGhcr
branch
3 times, most recently
from
af6d7fc to
31ddbf0
Compare
This adds support for automatically packaging and publishing Helm charts to GHCR. The feature includes: - New `pushHelmChartToGhcr` configuration in githubWorkflow with options for chart path, linting, dependency updates, and versioning - Automatic version detection from git tags (semver) or commit SHA - Chart.AppVersion synchronization with container image tags for seamless integration - Optional disabling of auto-versioning to use Chart.yaml version instead - Helm chart linting and dependency update support
notandy
force-pushed
the
pushHelmChartToGhcr
branch
from
31ddbf0 to
b4435a8
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This adds support for automatically packaging and publishing Helm charts to GHCR. The feature includes:
pushHelmChartToGhcrconfiguration in githubWorkflow with options for chart path, linting, dependency updates, and versioning