Open
Conversation
Change I8544efbdac207c54d75c55ee4a039c5324433794 was missing unit tests. Related-bug: #2069125 Change-Id: I9ab37f9d225a84fcceb9b618fad7d110974d2ed4 (cherry picked from commit 31c9721)
Access rule visibility and deletion locks were not being properly retrieved when listing, showing and deleting access rules, leading to an unexpected behavior. Fixes that issue by elevating the context and making sure that we are looking for all of the locks placed against the access rule. Closes-Bug: #2089061 Change-Id: Ib6667df25c8935826e673f180848887fe4fff8d6 Signed-off-by: Carlos Eduardo <ces.eduardo98@gmail.com> (cherry picked from commit 3d80e86) (cherry picked from commit 112791a)
Closes-bug: #2091102 Depends-On: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/940774 Change-Id: Ic8aaa0728a43936cd4c6e1ed590e01ba8f0fbf5b (cherry picked from commit d23862f) (cherry picked from commit 09f3ab0)
The CephFS NFS service may be configured to allow any or all NFS versions; Manila exports must not prevent that by only requesting NFS v4.0+ via export policies. Change-Id: If1cbeec2318f1b1bbd087cc2addf7f196fda8974 Closes-Bug: #2099273 (cherry picked from commit 314a391) (cherry picked from commit 8bc4003)
Depends-On: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/958516 Change-Id: Ia8dca192269944dda57af25efa44a14c2838f9a7 Signed-off-by: ricolin <rlin@vexxhost.com>
For server with no router specified in instance detail during teardown network, subnet will not be clean as code for clean subnet never executed. This change allows to cleanup subnet correctly. Change-Id: I856966f5994926424ae5421aba373daa999376d6 Signed-off-by: ricolin <rlin@vexxhost.com> (cherry picked from commit b4fe639) (cherry picked from commit 9afc5f384e8d6baa9561ee10aeebc0d9f48e71e4)
For Unity 5.x, port property `parent_storage_processor` is deprecated. Read port property `storage_processor` instead. Closes-Bug: #2020745 Change-Id: I085dbf2ad8eaaa7f1d43d5f0cb42fad5e18eca3d Signed-off-by: Yian Zong <yian.zong@dell.com> (cherry picked from commit be441c9) (cherry picked from commit 7c7fb88) (cherry picked from commit 8bb65b9)
New config option `driver_updatable_metadata` contains list of metadata keys. Share metadata if updated will be passed to backend driver if key is present in above list. Driver then can take action if supported and result will be updated in message. Implements: blueprint pass-resource-metadata-updates-to-backend-drivers Change-Id: If4297cca3249359f72976800db2112ea9c61c06f (cherry picked from commit 8c418e9)
Introduces a new API to allow OpenStack administrators to start the share manager's ensure shares operation. Also, introduced a new configuration option named `update_shares_status_on_ensure`, so administrators can define whether the shares status should be updated during the ensure shares operation or not. A new column was added to the services table, named `ensuring`. Through this field, we can identify whether there is an undergoing ensure shares operation or not. Closes-Bug: #1996793 Partially-Implements: bp ensure-shares-api Change-Id: If7bf059eb8581f20a3ceb7c1af93558774f4ef5e (cherry picked from commit 101becf)
This is a follow-up change to the ensure shares APIs [1]. An additional policy check was added, but it was not needed, as it was already being performed by the decorator, so we remove it. [1] https://review.opendev.org/c/openstack/manila/+/924279 Change-Id: Iab25d5a6a3906dfdb1cb3473188edcc5fafc80d4 (cherry picked from commit 697c9bf)
Updates to the end user, which allows them to specify metadata items that should be passed to backend share drivers. Share driver may take needed action from provided metadata if supported. partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers Change-Id: If595af5910706582165c11c30e73766c208f9b4e (cherry picked from commit debec43)
This patch adds support for Share Export Locations in the Metadata Controller. Co-Authored-By: Ashley Rodriguez <ashrod98@gmail.com> Partially-implements: bp metadata-for-share-resources Change-Id: Icf096a5cbc650f02eca68d714c876eb854499b9b (cherry picked from commit 2016062)
This change introduce a new extra spec netapp:efficiency_policy where the user can specify a pre-created NetApp efficiency policy from share located share-server. During share creation, User specified efficiency policy can be applied to the FlexVol/FlexGroup volume that corresponds to the Manila Share. Blueprint: manila-netapp-efficiency-policy Change-Id: I1ebc1b8ac6d70c4f525593d0fc75aa0cae2b22bf (cherry picked from commit 4353861)
Consider two metadata keys i.e. snapshot_policy and showmount. Partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers Depends-on: If4297cca3249359f72976800db2112ea9c61c06f Change-Id: I042a2caa5884ddea09ecfa0028d01758c18af5a3 (cherry picked from commit 52d423f)
The NetApp ONTAP driver now supports the SnapLock feature. New capability 'netapp_snaplock_type' has been added to the backend pool to create and schedule shares on the required WORM-supported pool. Extra spec, 'netapp_snaplock_type', can be used to create SnapLock volumes. Additionally, extra specs related to the SnapLock retention period have been introduced to set the retention period on SnapLock volumes. Implements: blueprint snaplock-support-for-manila-driver Change-Id: I73c4d027852fbfbbdab59538cbe23ba1487da0de (cherry picked from commit 0892de0)
Update API will only allow to update access_level of access_type. Pass the information to share drivers and let them handle update access rule if supported. Closes-bug: #2066871 Change-Id: Ieb836d7e63ce8bb14c4ae4fc57b012ee3249dcc7 (cherry picked from commit 65d48c0)
After the access rule update change has been merged [1], the NFS Ganesha protocol crashes while creating or removing access rules and produces an ugly stacktrace [2]. This change adds the missing parameter to the protocol helper update_access method. [1] https://review.opendev.org/c/openstack/manila/+/931050 [2] https://paste.opendev.org/show/bLQFGAZWngnFJpTllTAY/ Closes-Bug: #2098090 Change-Id: Icb67434ada6c58a299b799ca3a5225a280df22ad (cherry picked from commit c153f2e)
Adds a simple text about the changes introduced by API version 2.88 Change-Id: I450bf333075fd7554782845488818deb44ef5baa (cherry picked from commit 5f11287)
After the access rule update change has been merged [1], there are few places where protocol helpers are not updated. This change adds the missing parameter to the protocol helper update_access method. [1] https://review.opendev.org/c/openstack/manila/+/931050 Closes-Bug: #2098090 Change-Id: I50db5078dd53730fd437c5868d0817c44adfa129 (cherry picked from commit b1be38a)
- Share network subnet metadata if updated and metadata keys are present in config option 'driver_updatable_subnet_metadata', then metadata will be passed to backend driver. Driver then can take action and the result will be communicated in user message. For delete operation, if metadata updatable by driver exist with resource, user message will be added and delete will be performed. - Supported from microversion '2.89'. Implements: blueprint pass-resource-metadata-updates-to-backend-drivers Change-Id: I2f81fed925cfcd1ac8b99472cd836c2b339ee487 (cherry picked from commit eb131b9)
Consider metadata 'showmount' and use existing method update_showmount() Consider metadata 'pnfs' and use new method update_pnfs() Depends-On: https://review.opendev.org/c/openstack/manila/+/929091 Partially-implements: blueprint pass-resource-metadata-updates-to-backend-drivers Change-Id: Ibbe0ed2b1b94fe744169d26071cc6754fdec53c4 (cherry picked from commit f02c422)
The NetApp driver now support to prevent the creation of a share server if the total number of data LIFs on one node of HA pair, including those that can be migrated in case of failure, exceeds the maximum number data LIFs supported by the node. Config option 'netapp_restrict_lif_creation_per_ha_pair' is added to guarantees that, in the event of a node failure, the partner node will be able to takeover all data LIFs Closes-Bug: #2100835 Change-Id: Ibb5396de3ced3afd324010bacbd29a4f2eb3368e (cherry picked from commit ab8fa6b)
Since we allow share server migration with share replica, we need to make sure correct share and snapshot instances updated to 'server_migrating' status i.e. instances belonging to share server under migration. Fixed this. Closes-bug: #2104357 Change-Id: I3bb7bfa4942d67c128285a46a740f335d92fc70f (cherry picked from commit 27d00fd)
sumitarora2786
approved these changes
Oct 16, 2025
chuan137
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.