Conversation
SuperSandro2000
requested review from
a team,
crenduchinta88 and
sumitarora2786
as code owners
wagnerd3
requested changes
Feb 19, 2026
Contributor
wagnerd3
left a comment
wagnerd3
left a comment
There was a problem hiding this comment.
I think pkg/actors/report.go:126 should be taken care of manually?
SuperSandro2000
force-pushed
the
fix-linter
branch
from
6820ebd to
8065f58
Compare
majewsky
previously requested changes
Feb 23, 2026
pkg/actors/report.go
Outdated
| err := statter.Gauge(bucket, value, 1.0) // 1.0 is the `rate` argument | ||
| if err != nil { | ||
| logg.Error("statsd: could not submit value %d for bucket %q: %s", value, bucket, err.Error()) | ||
| return |
Contributor
There was a problem hiding this comment.
This return is pointless, because the function ends immediately after.
SuperSandro2000
force-pushed
the
fix-linter
branch
from
8065f58 to
3822200
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
wagnerd3
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the other failures hopefully resolve with the next gomm run or golangci-lint update.