Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STF] Adds direct access to open an editor #1084

Closed
wants to merge 1 commit into from
Closed

Conversation

srossbach
Copy link
Contributor

Adds support for bypassing the GUI when opening an editor for a specific
file.

Adds support for bypassing the GUI when opening an editor for a specific
file.
@srossbach srossbach requested a review from tobous September 11, 2020 23:51
@tobous
Copy link
Member

tobous commented Oct 19, 2020

These changes are no longer necessary in my opinion. It was not an issue with the upstream API but rather with the setup of the projects on the invitee's side. I described this in more detail in #1040.

@srossbach
Copy link
Contributor Author

Thanks for spending so much time to find the issue 👍 . I am still confused why user input on the IDE is necessary to detect project nature changes. Looking at the documentation this should be done on the fly when you modify the .project file. I looked at the modifications but in my opinion it still hard to understand what is going on, especially for new developers. You read the code and ask yourself, why does I have to create an empty stub project ? This should be hidden somewhere in the Util / Superbot methods in my opinion. Still wondering if a simply project refresh could do the trick although t his will increase testing time again.

@tobous
Copy link
Member

tobous commented Oct 21, 2020

Thanks for spending so much time to find the issue 👍. I am still confused why user input on the IDE is necessary to detect project nature changes. Looking at the documentation this should be done on the fly when you modify the .project file.

I think it does happen in the background occasionally, which is why some of the tests succeeded some of the time. But this background-refresh probably only happens periodically, e.g. every 10 seconds or so. At least that would be my guess.

I looked at the modifications but in my opinion it still hard to understand what is going on, especially for new developers. You read the code and ask yourself, why does I have to create an empty stub project? This should be hidden somewhere in the Util / Superbot methods in my opinion.

This is mostly hidden in the Util method. The only case where this is not hidden is when a single participants participant is added to a running session using the super bot directly instead of utility methods. I decided to adjust the code to create the project and use it instead of re-writing the tests.

Still wondering if a simply project refresh could do the trick although t his will increase testing time again.

I tried fixing this by refreshing the project on the sending and receiving side but it was very inconsistent. I am not sure why, but my guess would be that the timings during the test are quite tight and the refresh happened while the resources were already being processed.

@tobous
Copy link
Member

tobous commented Nov 10, 2020

@srossbach I don't see a reason to keep this PR around. Do you still have a use for it? Otherwise I would close it.

@tobous
Copy link
Member

tobous commented Jan 6, 2021

Superseded by #1040.

@tobous tobous closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants