[INTERNAL][UI] Use new XMPPStore API

[srossbach]

This patch introduces the usage of the new XMPPStore API.

Renaming UI buttons is not done yet as changing UI values is likely to
crash the whole STF.

[tobous]

@m273d15 Any idea why the Codacy build fails? I tried restarting it, but it did not help. Otherwise, I will contact the codacy support.

@srossbach Did you change the base of this PR directly after pushing to the PR branch (while the build was still running)? This caused issue for me in the past.

[srossbach]

I do not know what cause this. I am already facing the problem that my commit message is not insert here. I will have to look at EGIT again if it is possible to add a reference on a remote branch. Currently I am doing this in Github when creating the pull request. Maybe it is possible that I changed the branch during build.

[tobous]

What do you mean by "that your commit message is not inserted here"? Do you mean that the commit message is actually not attached to the commit or that the commit message is not automatically entered in the PR description?

If its the second one, this is due to us now having a PR template that is used instead. So you have to do the same you also have to do when creating PRs containing multiple commits, i.e. copy the message and put it in the PR description by hand. At least that is how I have been doing it. Maybe there is a better way or a plugin that helps you with it, but this would be news to me.

[srossbach]

Sometimes my commit message is included in the PR and the template is appended. Sometimes only the template is present.

[tobous]

Ok, either I am missing something or there are a lot of potential NPEs in the connection logic with the new change to allow no default account to be set. It seems to often have been used as a general fallback, which is now problematic.

[tobous]

Needs to be rebased and there is still my question about a possible NPE. But looks good otherwise.

[srossbach]

I just noticed I missed the server. Will add it in the next commit.

[tobous]

Looks good to me. Did not check whether there are any other usages of the old (now deprecated) methods.

[srossbach]

Should be easily revealed when rebasing #615 .

[tobous]

@srossbach From my experience, the Travis build for the Pull Request will never come in (in the current state). This is an issue that seems to occur when (force-) pushing to a branch and then immediately changing the base branch while it is still building.

This can only be solved by pushing something new to the branch (i.e. amending a commit and force-push again). But, since the branch build succeeded, this can probably be ignored. It should still be avoided if possible (e.g. by changing the base branch before pushing/updating the PR).

[srossbach]

@tobous thank you for the information. I am still used to Gerrit which updated the branches automatically.