Bad code fragment #2967
Closed
Bad code fragment #2967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to allocate memory for data context..
|
I'm also on it: #2968 |
|
I've merged my doc changes, please see if anything else should be added. Thanks! |
|
That’s brilliant.
On a different note, an earlier version of libsass would send some error and warning messages to “cerr” - I’m hoping that this doesn’t happen any more? Is there an option to be able to add a custom logging handler? I think we are currently parsing the return string..
… On 8 Aug 2019, at 06:18, Marcel Greter ***@***.***> wrote:
I've merged my doc changes, please see if anything else should be added. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
We still print to stderr, see #2862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to allocate memory for data context..