fix: docker terratest#577
Open
Carus11 wants to merge 8 commits into
Open
Conversation
Install ca-certificates bundle for the azure cli installation Signed-off-by: Carus Kyle <caruskyle@gmail.com>
Signed-off-by: Carus Kyle <caruskyle@gmail.com>
Signed-off-by: Carus Kyle <caruskyle@gmail.com>
Signed-off-by: Carus Kyle <caruskyle@gmail.com>
Signed-off-by: Carus Kyle <caruskyle@gmail.com>
Contributor
Author
|
Ah I see someone else fixed the terratest image. Still I'll leave this one up as an alternative to |
|
This PR is stale because it has been open 30 days with no activity. |
github-actions
Bot
added
bug
|
This PR is stale because it has been open 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up the Dockerfile to stop the Azure CLI installation from failing.
What's changed:
Switched from the curl | bash script to the official repo.
Added specific cleanup commands for apt to keep the image size down and pinned the base image to bookworm for stability.
Bumped the base image version to golang 1.26 to match the @latest version of terratest, but then pinned that version. This I think was causing the error as the latest version of terratest was updated and the minimum golang version was bumped to 1.26.