fix: when ACR is enabled automatically setup acr pull permission#595
Open
Carus11 wants to merge 1 commit into
Open
fix: when ACR is enabled automatically setup acr pull permission#595Carus11 wants to merge 1 commit into
Carus11 wants to merge 1 commit into
Conversation
… kubelet Signed-off-by: Carus Kyle <caruskyle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400
This change automatically sets up acr pull permission from the kubernetes cluster. This aligns with current security guidelines of not using static credentials (a docker login secret), and the other principal of secure by default.
Additionally it introduces a parameter to name the acr, to help ensure global uniqueness. Previously there were some global uniqueness problems using only
{prefix}acr.