Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qqguild): fix image was parsed twice #127

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

ltxhhz
Copy link
Contributor

@ltxhhz ltxhhz commented Jul 4, 2023

那部分代码解析了两次图片

@shigma shigma requested a review from NWYLZW July 4, 2023 16:34
Copy link
Contributor

@NWYLZW NWYLZW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这都能被你发现吗,神奇

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #127 (c4ccec9) into master (985e033) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files           1        1           
  Lines         424      424           
  Branches       86       86           
=======================================
  Hits          347      347           
  Misses         77       77           

@ltxhhz
Copy link
Contributor Author

ltxhhz commented Jul 5, 2023

这都能被你发现吗,神奇

LGTM

可能频道的开发者没几个🤣

@NWYLZW
Copy link
Contributor

NWYLZW commented Jul 5, 2023

可能频道的开发者没几个🤣

主要我觉得作为用户,你不去看源码应该发现不了这个问题🤔️

@ltxhhz
Copy link
Contributor Author

ltxhhz commented Jul 5, 2023

可能频道的开发者没几个🤣

主要我觉得作为用户,你不去看源码应该发现不了这个问题🤔️

开发过程中觉得不对就去打断点了,之前也干过,轻车熟路👍

@shigma shigma merged commit 3354eea into satorijs:master Jul 7, 2023
@ltxhhz ltxhhz deleted the patch-1 branch July 8, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants