feat!: use method list #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior a string with a delimiter (`,`) was used for enabling and disabling methods. YAML has a built in list type, so this change enables the use of that.
dianwen
approved these changes
Jun 5, 2023
Author
|
I don't think I can release this since I am not a member of satsuma :) |
Member
|
Apologies, I thought you were a Satsuma team member when I first glanced at the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior a string with a delimiter (
,) was used for enabling and disabling methods. YAML has a built in list type, so this change enables the use of that.Type of change
How Has This Been Tested?
Updated the unit tests, working against a private testnet.