-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ensemble): default verdict is Binoculars-driven (fixes the 71% non-native FPR) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ class EnsembleAnalyzer(BaseAnalyzer): | |
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
| self.method_name = "Ensemble (GPT2+NLTK)" | ||
| self.method_name = "Ensemble (Binoculars-weighted)" | ||
| self.ensemble_config = self.settings.ensemble | ||
|
|
||
| # Initialize analyzers | ||
|
|
@@ -452,9 +452,12 @@ def _generate_ensemble_explanation( | |
| ) | ||
|
|
||
| parts.append( | ||
| f"\n⚖️ **Weights**: RoBERTa {self.weights['roberta'] * 100:.0f}%, " | ||
| f"\n⚖️ **Verdict weights**: Binoculars {self.weights['binoculars'] * 100:.0f}%, " | ||
| f"GPT-2 {self.weights['gpt2'] * 100:.0f}%, " | ||
| f"NLTK {self.weights['nltk'] * 100:.0f}%." | ||
| f"NLTK {self.weights['nltk'] * 100:.0f}%, " | ||
| f"RoBERTa {self.weights['roberta'] * 100:.0f}%. " | ||
| f"GPT-2/NLTK scores are shown for transparency but do not drive the " | ||
| f"default verdict — see docs/benchmarks/FAIRNESS.md." | ||
|
Comment on lines
+455
to
+460
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Preserve compatibility with custom weight maps.
🤖 Prompt for AI Agents |
||
| ) | ||
|
|
||
| # Key metrics | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Update the stale Binoculars setup instructions.
This new row says Binoculars is enabled by default, but the later Binoculars section still says it is not in the default ensemble and must be given a non-zero weight. Update that section to describe the current
weight_binoculars=1.0default.🤖 Prompt for AI Agents