Open
Conversation
SanchayGupta97
requested changes
Aug 19, 2021
Collaborator
SanchayGupta97
left a comment
SanchayGupta97
left a comment
There was a problem hiding this comment.
good job, few minor comments
src/main/java/com/employee/employeemanagementsystem/entities/Employee.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/entities/Employee.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/entities/Employee.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/entities/Employee.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/entities/User.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/entities/User.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/repository/EmployeeRepository.java
Show resolved
Hide resolved
…ard employees, add function to create employee email id
src/main/java/com/employee/employeemanagementsystem/entities/Employment.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/exceptions/MyCustomException.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/services/EmployeeServices.java
Outdated
Show resolved
Hide resolved
src/main/java/com/employee/employeemanagementsystem/services/EmployeeServices.java
Outdated
Show resolved
Hide resolved
| //there could be only one email id with no trailing number, so checking it | ||
| if (lastEmail.matches(".*[0-9]")) { | ||
| //if there is already a number at the end, increment the number and append it to the id | ||
| int val = lastEmail.charAt(lastEmail.length() - 1) - '0'; |
Collaborator
There was a problem hiding this comment.
What happens when there are multiple digits appended at the end?
Collaborator
There was a problem hiding this comment.
ie when you need to shift from 19 to 20 ;29-30 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.