Extract style tags and non dialogue words. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhshri
requested changes
Jan 15, 2018
srtparser.h
Outdated
| if(tag[0] == '/'){ | ||
| tag.erase(0,1); | ||
| } | ||
| _nonDialogue.push_back(tag); |
There was a problem hiding this comment.
This will insert tags into nonDialogue vector.
srtparser.h
Outdated
| else if(c == '>') | ||
| { | ||
| c = '~'; | ||
| countP--; | ||
| _styleTagCount++; | ||
| if(tag[0] == '/'){ | ||
| tag.erase(0,1); |
There was a problem hiding this comment.
This will not erase complete enclosing tag. If it starts with </, it need not be stored.
There was a problem hiding this comment.
Additionally <font></font> and all such pairs should be counted as a singular unit.
There was a problem hiding this comment.
I'm not adding the < and > characthers. I'm ignoring them and only adding till it doesn't equal >. The problem with that approach was the / characther will get added and since i'm not adding < it's /font for example and it'll always be first.
srtparser.h
Outdated
| int countP = 0; | ||
| std::string tag; |
saurabhshri
requested changes
Jan 15, 2018
srtparser.h
Outdated
| else{ | ||
| _styleTag.push_back(tag); | ||
| tag=""; | ||
| } |
There was a problem hiding this comment.
This if else block can be simplified to a single if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #2