HOTFIX: Fix crossfade sequence when having a tail after transition. #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
sequence-single-track-v2.2.x
branch
4 times, most recently
from
0e74f8e to
e2dec7c
Compare
toots
force-pushed
the
sequence-single-track-v2.2.x
branch
from
e2dec7c to
a11d727
Compare
|
Hi @toots, |
|
I usually re-create the |
toots
added a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem in the new mechanism to compute crossfade over the common buffer: this code:
Will skip over to
after_tailon the first track mark from the coumpound source.It seems good to try and keep the new crossfade computation over the common buffer so, the safe solution is to add a new, opt-in behavior to
sequencethat allows it to play from the same source while it is available instead of moving to the next source on the first track mark.This is achieved by the new
single_trackoption, sets to the default, current behavior (true).This will require a bump of the release assets.