Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtile bug in HLS muxing:
This is tricky to fix so the changes here:
This shows good behavior with normal encoding params.
Some users will still need to forcefully set
interleaved = false
on the encoder.The reason we're not doing this by default on hls streams is that this can also result in un-balanced A/V streams where too much audio is present etc.
tl;dr: HLS is hard and to make it work you need to properly understand your configuration. But for simple use-case like audio-only streams, this should behave just fine.
Fixes: #4398