port scala-stdlib for Scala.js

[hamzaremmal]

No description provided.

[sjrd]

Suggested change

	|| denot.is(Param) && denot.maybeOwner.is(Method) && denot.maybeOwner.maybeOwner.is(Scala2x) then
	|| denot.is(Param) && denot.maybeOwner.is(Method) && denot.maybeOwner.maybeOwner.lastKnownDenotation.is(Scala2x) then

to be consistent with the method case?

We might also need to exclude the params of Inline methods? I don't know when that actually happens. What is even an Inline Scala 2 method?

[hamzaremmal]

We might also need to exclude the params of Inline methods? I don't know when that actually happens.

I actually don't know yet what happened. I was curious too but not had the time yet to investigate. The only thing I know is that it was added by @jchyb.

What is even an Inline Scala 2 method?

For now, I genuinely don't know... but I know that when we will add an inline def in scala.collection.Seq, we will have an inline Scala2 method.

[jchyb]

In my defense, this precedes my changes: 6e58d25#diff-7cbbe7d1307696dd5d37afe4ce94c01f85f4945edb2c37b113245ad8c85264c1L30 .
I was only interested in making sure we are not recalculating the denotation, and likely missed the weird nature of the check there. That is to say, I don't know what that is either :(

[hamzaremmal]

In my defense, this precedes my changes: 6e58d25#diff-7cbbe7d1307696dd5d37afe4ce94c01f85f4945edb2c37b113245ad8c85264c1L30 .

I didn't meant to blame you for this, I only relied on what VSCode showed me for on git blame when I did the change.

[sjrd]

OK looks good. There's probably something to investigate further for those "Scala 2 inline" things in the future.

[hamzaremmal]

There's probably something to investigate further for those "Scala 2 inline" things in the future.

There is, I agree.