Adding unknown fields when parsing fieldoptions from javaproto #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests for this (yet). And I don't know if this can/should be repeated for other environments (like js-native).
…_fieldoptions_from_javaproto
|
Thanks for working on this. Can you add tests under e2e?
…-Nadav
On Thu, Sep 11, 2025, 8:34 AM Kristofer Jarl ***@***.***> wrote:
I created an issue for this here
<#1908>. It didn't get any
attention, but I'll just go ahead and try a PR.
Please let me know if I need to make any changes. Thanks.
------------------------------
You can view, comment on, or merge this pull request online at:
#1963
Commit Summary
- 58c9e61
<58c9e61>
Adding unknown fields to FieldOptions.fromJavaProto
- 7b0b2ed
<7b0b2ed>
Merge branch 'scalapb:master' into
Adding_unknown_fields_when_parsing_fieldoptions_from_javaproto
File Changes
(1 file <https://github.com/scalapb/ScalaPB/pull/1963/files>)
- *M*
scalapb-runtime/src/main/scalajvm/com/google/protobuf/descriptor/FieldOptions.scala
<https://github.com/scalapb/ScalaPB/pull/1963/files#diff-fc44fd13b01c4f727cad7bb1f206450d99098da838ad0562bc90b98b0ba3456c>
(18)
Patch Links:
- https://github.com/scalapb/ScalaPB/pull/1963.patch
- https://github.com/scalapb/ScalaPB/pull/1963.diff
—
Reply to this email directly, view it on GitHub
<#1963>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACLBLNEBYMAQIABCXCHM5L3SGI7RAVCNFSM6AAAAACGIEDP3GVHI2DSMVQWIX3LMV43ASLTON2WKOZTGQYDOMBZGIYDKMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Thanks. I'll do what I can to add some tests. Not very familiar with this framework. I'll get back to you when I have an update. |
No tests for this (yet). And I don't know if this can/should be repeated for other environments (like js-native).
…ng_fieldoptions_from_javaproto' into Adding_unknown_fields_when_parsing_fieldoptions_from_javaproto
This validates that the extensions are properly populated in the descriptor after being fully serialized/deserialized.
|
I added a test for this. The test would fail before this PR, but now it runs successfully. |
|
AFK for the next 3 weeks. Will review when I am back
…-Nadav
On Wed, Sep 17, 2025 at 3:17 PM Kristofer Jarl ***@***.***> wrote:
*silverbeak* left a comment (scalapb/ScalaPB#1963)
<#1963 (comment)>
I added a test for this. The test would fail before this PR, but now it
runs successfully.
Please let me know if this is not what you had in mind.
—
Reply to this email directly, view it on GitHub
<#1963 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACLBLPFEQBRV7HXC4UQDJL3TEKKZAVCNFSM6AAAAACGIEDP3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMBRHA2TMOBVGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an issue for this here. It didn't get any attention, but I'll just go ahead and try a PR.
Please let me know if I need to make any changes. Thanks.