-
Notifications
You must be signed in to change notification settings - Fork 0
Remove generic contracts-related docs from 3.12 sidebar navigation #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generic contracts-related docs from 3.12 sidebar navigation #1019
Conversation
Since generic contracts are part of HashStore and TableStore, which were introduced in 3.12, users don't need to refer to setting up generic contracts in another way.
Summary of ChangesHello @josh-wong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR removes generic contracts-related documentation links from the 3.12 sidebar navigation in both English and Japanese versions of the documentation. This change reflects that generic contracts are now implicitly covered by ScalarDL HashStore and TableStore, making standalone setup guides for generic contracts unnecessary for the latest version. The underlying documentation pages will persist but will be deprecated in a subsequent PR and are already excluded from search results for version 3.12. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for this contribution. The changes to remove the generic contracts-related documentation links from the sidebar for version 3.12 are clear and well-justified in the pull request description. The modifications in sidebars.js
are consistent for both the English and Japanese documentation. I've reviewed the changes and they look good. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
This PR removes all sidebar links related to generic contracts from both the English and Japanese documentation navigation in the
sidebars.js
file, which contains the latest version (3.12) of the docs. Since generic contracts are part of ScalarDL HashStore and ScalarDL TableStore, which were introduced in 3.12, users don't need to refer to setting up generic contracts in another way.Note
As discussed:
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A