Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical fix to the 3.11 branch, significantly enhancing the PutToMutable function's capability to handle a broader range of data types. Specifically, it addresses the correct processing of FLOAT and BLOB values within JSON arguments, alongside introducing support for several other data types in the schema. The changes include updates to the schema definition, refined data type parsing logic, and comprehensive integration tests to ensure the robustness and accuracy of data persistence for these new types, including scenarios with null values.

Highlights

  • Expanded Data Type Support: The objects-table-schema.json now includes BOOLEAN, BIGINT, FLOAT, DOUBLE, TEXT, BLOB, DATE, TIME, and TIMESTAMPTZ column types, significantly broadening the data types that can be handled.
  • Improved FLOAT Handling: The PutToMutableDatabase function's logic for FLOAT values has been updated to correctly account for JSON deserialization, where floating-point numbers are typically represented as doubles.
  • Enhanced BLOB Handling: BLOB data is now expected as Base64-encoded strings within JSON arguments, aligning with standard practices for representing binary data in JSON.
  • Comprehensive Integration Tests: New and updated integration tests in GenericContractObjectAndCollectionEndToEndTest.java validate the correct handling of all newly supported data types, including scenarios with null values, ensuring robust data persistence.
  • Automated Backport: This pull request is an automated backport of a previous fix (original PR Fix to handle FLOAT and BLOB data types in PutToMutable function #297, commit f811d359956479218c8a42bbb329363b62fd48cb) to the 3.11 branch, ensuring consistency across versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a fix to correctly handle FLOAT and BLOB data types in the PutToMutableDatabase function. The changes correctly adjust the deserialization logic for these types, considering JSON's limitations. The associated unit and integration tests are also updated to reflect these changes and add broader test coverage for various data types, including null values. The changes are well-implemented, but I found a critical issue in a new integration test that will cause a compilation failure.

@jnmt jnmt merged commit 95e02a3 into 3.11 Oct 29, 2025
5 of 8 checks passed
@jnmt jnmt deleted the 3.11-pull-297 branch October 29, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants