Backport to branch(3) : Fix to handle FLOAT and BLOB data types in PutToMutable function

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix to handle FLOAT and BLOB data types in PutToMutable function #297
• Backported commit: f811d35

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that introduces crucial fixes for the PutToMutable function, enabling it to properly process FLOAT and BLOB data types. The changes involve adjusting the data handling logic to align with JSON serialization behaviors and expanding the test suite to validate the correct storage and retrieval of these types, including null values, across various scenarios.

Highlights

• Expanded Data Type Support: The PutToMutable function now correctly handles FLOAT and BLOB data types, addressing previous limitations in their serialization and deserialization within JSON arguments.
• JSON Deserialization Logic Update: The internal getColumn method has been refined to account for how JSON deserializers handle numeric types (treating FLOAT values as DOUBLE) and binary data (expecting BLOB as Base64-encoded strings).
• Comprehensive Testing: New integration and unit tests have been added or updated to cover the correct handling of FLOAT, BLOB, and other data types, including scenarios with null values, ensuring robustness.
• Schema Expansion for Testing: The objects-table-schema.json has been updated to include a wider range of data types (BOOLEAN, BIGINT, FLOAT, DOUBLE, TEXT, BLOB, DATE, TIME, TIMESTAMPTZ) for thorough testing of the generic contract.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a fix to correctly handle FLOAT and BLOB data types in the PutToMutable function. The changes in PutToMutableDatabase.java correctly adjust the logic for deserializing these types from JSON arguments, where floats are treated as doubles and blobs are expected as Base64-encoded strings. The integration and unit tests have been updated extensively to cover these new data types, including tests for null values. The changes are logical and well-implemented. I've added a couple of suggestions in the integration test to improve code maintainability by reducing duplication.

[gemini-code-assist]

This series of isNull checks is repetitive. To make the code more concise and maintainable, especially if more nullable columns are added in the future, you could group the column names into a List and then iterate over it to perform the assertion in a loop.

Suggested change

	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_3)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_4)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_BOOLEAN)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_BIGINT)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_FLOAT)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_DOUBLE)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_TEXT)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_BLOB)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_DATE)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_TIME)).isTrue();
	assertThat(results.get(0).isNull(SOME_COLUMN_NAME_TIMESTAMPTZ)).isTrue();
	ImmutableList.of(
	SOME_COLUMN_NAME_3,
	SOME_COLUMN_NAME_4,
	SOME_COLUMN_NAME_BOOLEAN,
	SOME_COLUMN_NAME_BIGINT,
	SOME_COLUMN_NAME_FLOAT,
	SOME_COLUMN_NAME_DOUBLE,
	SOME_COLUMN_NAME_TEXT,
	SOME_COLUMN_NAME_BLOB,
	SOME_COLUMN_NAME_DATE,
	SOME_COLUMN_NAME_TIME,
	SOME_COLUMN_NAME_TIMESTAMPTZ)
	.forEach(c -> assertThat(results.get(0).isNull(c)).isTrue());