Skip to content

Make --metadata take a JSON object#91

Open
pixelcat-user wants to merge 6 commits into
scaler-tech:masterfrom
pixelcat-user:json-metadata
Open

Make --metadata take a JSON object#91
pixelcat-user wants to merge 6 commits into
scaler-tech:masterfrom
pixelcat-user:json-metadata

Conversation

@pixelcat-user

Copy link
Copy Markdown

Background:

The metadata parsing as it exists today won't honor http:// schema names, which we need in order to support multiple IdP types, and specifically Microsoft Entra ID which uses schemas instead of simple strings.

As part of our implementation we store those schema names as mappings to field names in metadata, such as the following:

| Metadata        | Array                                                                                             
|                 | (                                                                                                             
|                 |     [field_email] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress
|                 |     [field_lastName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname
|                 |     [field_uniqueId] => http://schemas.microsoft.com/identity/claims/objectidentifier 
|                 |     [field_firstName] => http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname                     
|                 | )

Solution: Instead of mapping metadata to an array based on : as a separator, this PR allows users to specify metadata as a serialized JSON string during creation or update.

@breart

breart commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Great idea and thanks for your PR @pixelcat. I'd suggest keeping backward-compatibility, either dynamically check if JSON was provided and then treat as JSON or introduce a new option like --metadata-json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants