Skip to content

Conversation

@SylvainSenechal
Copy link
Contributor

ISSUE: CLDSRVCLT-7

@bert-e
Copy link

bert-e commented Dec 1, 2025

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@SylvainSenechal SylvainSenechal changed the base branch from development/1.0 to improvement/CLDSRVCLT-2 December 1, 2025 13:53
@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-7 branch 3 times, most recently from b0e8cbd to 23e792a Compare December 1, 2025 15:15
@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch 3 times, most recently from 17dca6a to b424f76 Compare December 3, 2025 11:06
@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-7 branch 4 times, most recently from a98c3be to 101daf6 Compare December 3, 2025 14:53
@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-2 branch 3 times, most recently from 58ae441 to dbfab6d Compare December 10, 2025 10:40
Base automatically changed from improvement/CLDSRVCLT-2 to development/1.0 December 10, 2025 14:24
@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-7 branch 2 times, most recently from fbf3b02 to fe68438 Compare December 10, 2025 14:57
@SylvainSenechal SylvainSenechal marked this pull request as ready for review December 10, 2025 14:59
@bert-e
Copy link

bert-e commented Dec 10, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Dec 10, 2025
Comment on lines 42 to 68
- name: Create Tag with Build Artifacts
run: |
# Configure git user to the GitHub Actions bot
git config --global user.name "github-actions[bot]"
git config --global user.email "github-actions[bot]@users.noreply.github.com"

# Force add the build folders (even if they are in .gitignore)
git add -f dist build

# Determine tag name
TAG_NAME="${{ inputs.tag }}"
if [ -z "$TAG_NAME" ]; then
TAG_NAME="test-${{ github.sha }}"
fi

# Commit the build artifacts
git commit -m "Build artifacts for version $TAG_NAME"

# Create the tag
git tag $TAG_NAME

# Push the tag to the repository
git push origin $TAG_NAME

# Export tag name for next step
echo "tag_name=$TAG_NAME" >> $GITHUB_OUTPUT
id: create_tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to push to git?

  • this creates releases outside of the development branches
  • this is not easily replicated for non-releases, which will makes testing integration more complex
  • the repo will not look the same at all for releases & dev, can be quite confusing
  • fundamentally, it uses Git as artifact storage.... while there is a dedicated tool: i.e. npm package registries...

→ should we not push to GitHub NPM registry ?
(there is an initial attempt here: scality/Guidelines#206)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rediscuss after or during daily, i'm not familiar with npm registry, but I feel like the current method is simple and relies and less dependency than having to work with npm

uses: ./.github/actions/setup-smithy

- name: Build project
run: yarn build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the "output" of yarn build get cached by setup-node, to speedup rebuilds?
if not, we should implement this kind of caching ourself (using actions/cache)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the release.yml, we can do it without caching.
But I've got the same problem in the test file, so I'm gonna check if I can add caching for the tests

@SylvainSenechal SylvainSenechal force-pushed the improvement/CLDSRVCLT-7 branch 15 times, most recently from c779af1 to 95b045b Compare December 15, 2025 13:38
Copy link

@DarkIsDude DarkIsDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Maybe just an update on the README with a new section How to use it but not mandatory. Congrats !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants