-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for aarch64 #34
Conversation
Hi @scarrazza, could you, please, have a look? Nowadays people make a lot of claims how beneficial it is to do calculations on ARM, but totally forget to invest in the support of software on ARM. Best regards, Andrii |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @andriish, thanks for this, it looks good to me.
This is great @andriish. With this we can also get Linux (c.f. conda-forge/qcdloop-feedstock#8). edit: @andriish Out of curiosity, have you patched |
@@ -66,7 +66,7 @@ configure_file( | |||
"${PROJECT_SOURCE_DIR}/src/qcdloop.pc.in" | |||
"${PROJECT_SOURCE_DIR}/src/qcdloop.pc" | |||
) | |||
|
|||
IF(${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andriish Doesn't this assume only the existence of x86
and aarch64
? Won't this break ppc64le
builds now?
Note: on aarch64, the float128 is equivalent to native long double and quadmath library does not exist.