-
Notifications
You must be signed in to change notification settings - Fork 332
Coagulation of several maintenance and bug fixes #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arunkannawadi
wants to merge
45
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reflect the changes that happened when we moved to httpx. Fixes an issue reported in #498.
The decrease is real, verified by manual counting.
Addresses #499.
resolve conflict between proxy format: HTTPX and Requests
resolve conflict between proxy format: HTTPX and Requests
Package name changed from `fake_useragent` to `fake-useragent`. Disclaimer: I'm the maintainer.
Update fake-useragent name in requirements.txt
Results from running codespell
Update citations by year data
… a single publication exists for the query. Added a unit test for search_pubs that tests for the previous problem.
Fixed an issue where search_pubs returns an empty response when only a single publication exists for the query.
changed line 61
Fixed test_bibtex unit test, updated CONTRIBUTING.md
…agically === Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Add codespell support (config, workflow to detect/not fix) and make it fix few typos
docs(quickstart): add conda to install option from github README.md
The current httpx doesn't support proxies arguments:
Update publication_parser.py to use to `select` from `find_all`.
for arrow errors, fallback to regex year extraction
Fallback to regex pub year exraction or empty string in case arrow fails to parse the date
Add in PDF link in publication fill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Enter the associated issue number.
Description
Describe your addition briefly to help the reviewers understand your contribution.
Checklist
develop
and notmain
.If you don't have a premium proxy, some of the tests will be skipped.
The tests that are run should pass without raising
MaxTriesExceededException
or other exceptions.