Restructure SPEC comments #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with scientific-python#369 - Remove originating discussion link from header - Update specs and process to point to the two relevant discussion categories
bsipocz
approved these changes
Jan 31, 2025
| @@ -5,7 +5,6 @@ date: 2021-12-16 | |||
| author: | |||
| - "Jarrod Millman <[email protected]>" | |||
| - "Aditi Juneja <[email protected]>" | |||
| discussion: | |||
| is-draft: true | |||
There was a problem hiding this comment.
We should remove the is-draft: true.
There was a problem hiding this comment.
Or is that being used now?
jarrodmillman
approved these changes
Jan 31, 2025
|
Multiple approvals, let's get this in 🔥 |
|
Draft is required to be true, I believe, but can check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with
#369